Get execution version from snapshot instead of state #6867
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #6867 +/- ##
===========================================
- Coverage 41.11% 34.48% -6.64%
===========================================
Files 2116 903 -1213
Lines 185737 78095 -107642
===========================================
- Hits 76368 26928 -49440
+ Misses 102952 49030 -53922
+ Partials 6417 2137 -4280
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
janezpodhostnik
force-pushed
the
janez/execution-version-from-snapshot
branch
4 times, most recently
from
168376a to
33bde51
Compare
janezpodhostnik
force-pushed
the
janez/execution-version-from-snapshot
branch
from
9c10352 to
8e753d9
Compare
zhangchiqing
approved these changes
Jan 14, 2025
| return func(ctx Context) Context { | ||
| ctx.ReadVersionFromNodeVersionBeacon = enabled | ||
|
|
||
| ctx = WithEntropyProvider(snapshot)(ctx) |
There was a problem hiding this comment.
better to add some comments explain how it works for the two lines.
There was a problem hiding this comment.
The comment is already on the WithEntropyProvider and on the snapshot.RandomSource I don't think it will help adding it here as well
move snapshot provider move snapshot state provider cleanup
janezpodhostnik
force-pushed
the
janez/execution-version-from-snapshot
branch
from
8e753d9 to
f4d3c67
Compare
peterargue
approved these changes
Jan 15, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
work towards: #6507
Execution version was being read by calling a contract function on the service account. This meant it was read from the execution state. To reduce the impact on execution time it was put in the programs cache next to metering settings (execution effort weights, memory metering weights, memory limit).
The programs cache currently has a problem where it is invalidated on every block. This is due to the metering settings being inlined into the same register as the random beacon history. Since the random beacon history changes on every block, we have no choice but to also invalidate the metering settings. This in turn invalidates the entire programs cache. (programs cache entries contain programs and the execution effort it took to read them, which is derived from the metering settings).
The solution to the programs cache being invalidated on every block, is to move the metering settings to a separate, low/no traffic, account. However this solution does not work for the version beacon data, which would also need to be moved. Moving the version beacon data to a different account is much much harder as it has a lot of dependencies outside of execution.
In this PR I changed the FVM to instead read the version beacon data from protocol snapshot. We already read the Entropy source from the protocol snapshot, so I bundled these two things into a subset of the protocol snapshot that the FVM consumes for execution. This also prepares us for the future, where the execution version is going to be inside the dynamic protocol state (on the protocol snapshot).